From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Herton Ronaldo Krzesinski <herton@mandriva.com.br>,
Hin-Tak Leung <htl10@users.sourceforge.net>,
linux-wireless@vger.kernel.org
Subject: Re: [RFT/RFC] rtl8187: Remove some magic numbers
Date: Mon, 13 Apr 2009 11:51:44 +0200 [thread overview]
Message-ID: <1239616304.8243.0.camel@johannes.local> (raw)
In-Reply-To: <49e28a0e.w2E55OwYOA9yeg+w%Larry.Finger@lwfinger.net> (sfid-20090413_024115_059324_BFAA839F)
[-- Attachment #1: Type: text/plain, Size: 311 bytes --]
On Sun, 2009-04-12 at 19:40 -0500, Larry Finger wrote:
> - rtl818x_iowrite16(priv, (__le16 *)0xFFF4, 0xFFFF);
> + rtl818x_iowrite16(priv, &priv->map->FEMR, 0xFFFF);
That looks strange -- I can tell it works because priv->map is set to
0xFF00, but wouldn't actual constants make more sense?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-04-13 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 0:40 [RFT/RFC] rtl8187: Remove some magic numbers Larry Finger
2009-04-13 9:51 ` Johannes Berg [this message]
2009-04-13 15:39 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2009-04-13 7:43 Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239616304.8243.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).