Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
	Hin-Tak Leung <htl10@users.sourceforge.net>,
	Herton Ronaldo Krzesinski <herton@mandriva.com.br>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Hin-Tak Leung <hintak.leung@gmail.com>
Subject: Re: [PATCH RFC] mac80211: don't ask drivers to retry transmitting NO_ACK  frames
Date: Wed, 15 Apr 2009 00:37:32 +0200	[thread overview]
Message-ID: <1239748653.4205.27.camel@johannes.local> (raw)
In-Reply-To: <69e28c910904141534w7ed9b36w817f1862ff015286@mail.gmail.com> (sfid-20090415_003523_455143_EF283A5E)

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

On Wed, 2009-04-15 at 00:34 +0200, Gábor Stefanik wrote:
> Set the total count of TX tries to 1 if IEEE80211_TX_CTL_NO_ACK is
> set. This fixes a bug where mac80211 allowed the RC algo to request
> drivers to forcibly retransmit NO_ACK (e.g. multicast) frames until
> the excessive-retries limit is reached.

Why not fix the rate control algorithms to use the no-ack flag instead
of is_multicast?

> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> 
> ---
> Patch also available as attachment in case Gmail linewraps it.

You need to get a proper MUA.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2009-04-14 22:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14 22:34 [PATCH RFC] mac80211: don't ask drivers to retry transmitting NO_ACK frames Gábor Stefanik
2009-04-14 22:37 ` Johannes Berg [this message]
2009-04-14 22:47   ` Gábor Stefanik
2009-04-14 23:07     ` Gábor Stefanik
2009-04-15  0:00     ` Hin-Tak Leung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239748653.4205.27.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=herton@mandriva.com.br \
    --cc=hintak.leung@gmail.com \
    --cc=htl10@users.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netrolller.3d@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox