Re: p54 problem with PS

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]


> Well, I guess I figured out what's wrong: the hw spec.
> So this patch might work on PCI & USB, but could break SPI devices.

Heh.

> Johannes, can you please test the attached patch?
> 
> BTW: there might be two problems:
> 1. if the timeout is too low the device might be fast enough to go into ps:
>   -  either before sending a probe request
>    (firmware reports tx_status TX_PSM, so the frame wasn't sent at all)
>   - or the AP got the request and responded... 
>     But the frame was lost, because probe responds are not buffered...

?

> 2. there was something wrong in ieee80211_rx_mgmt_beacon
>     Sometimes the TIM was parsed, but thanks to
>     local->hw.conf.dynamic_ps_timeout == 0
>     mac80211 didn't issue a wakeup => so no data => disconnect
> 
>     But this bug maybe comes from the old RFCs from yesterday,
>     as I didn't tried the final version yet...

I didn't change that -- Kalle did that, see the comment there. I guess
we need to change that then.

> Oh and one question:
> Some time ago, I found some useful function that converted beacon_int TUs <-> msec,
> do we still have them somewhere around and I'm just (temp) blind ?

I just added TU -> msec in one of my patches to include/linux/ieee8021.h

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]