From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Kalle Valo <kalle.valo@iki.fi>,
Christian Lamparter <chunkeey@web.de>,
Vivek Natarajan <vivek.natraj@gmail.com>
Subject: Re: [PATCH 2.6.30!] mac80211: validate TIM IE length
Date: Fri, 17 Apr 2009 00:21:38 +0200 [thread overview]
Message-ID: <1239920498.26575.38.camel@johannes.local> (raw)
In-Reply-To: <1239920291.26575.37.camel@johannes.local> (sfid-20090417_001849_051533_DC947D05)
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
On Fri, 2009-04-17 at 00:18 +0200, Johannes Berg wrote:
> The TIM IE must not be shorter than 4 bytes, so verify that
> when parsing it and use the proper type. To ease that adjust
> struct ieee80211_tim_ie to have a virtual bitmap of size
> at least 1.
>
> Also check that the TIM IE is actually present before trying
> to parse it!
>
> Because other people may need the function, make it a static
> inline in ieee80211.h.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> I can provide a shorter fix for 2.6.30 if required.
>
> Kalle!!
Oops, sorry, that was Vivek :)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-04-16 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 22:18 [PATCH 2.6.30!] mac80211: validate TIM IE length Johannes Berg
2009-04-16 22:21 ` Johannes Berg [this message]
2009-04-16 22:54 ` [PATCH 2.6.30] " Johannes Berg
2009-04-18 15:33 ` [PATCH 2.6.31 v2] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239920498.26575.38.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=chunkeey@web.de \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox