From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Add set/get for frag/rts threshold and retry limits
Date: Fri, 17 Apr 2009 21:29:33 +0200 [thread overview]
Message-ID: <1239996573.5110.12.camel@johannes.local> (raw)
In-Reply-To: <20090417184629.GA9275@jm.kir.nu> (sfid-20090417_204656_419019_FC59D391)
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
> + if (changed & WIPHY_PARAM_RTS_THRESHOLD) {
> + if (local->ops->set_rts_threshold)
> + local->ops->set_rts_threshold(local_to_hw(local),
> + wiphy->rts_threshold);
> + }
That could return an error. (so do the changes the other way around)
> + if (changed & WIPHY_PARAM_RETRY_SHORT)
> + rdev->wiphy.retry_short = retry_short;
> + if (changed & WIPHY_PARAM_RETRY_LONG)
> + rdev->wiphy.retry_long = retry_long;
> + if (changed & WIPHY_PARAM_FRAG_THRESHOLD)
> + rdev->wiphy.frag_threshold = frag_threshold;
> + if (changed & WIPHY_PARAM_RTS_THRESHOLD)
> + rdev->wiphy.rts_threshold = rts_threshold;
> +
> + result = rdev->ops->set_wiphy_params(&rdev->wiphy, changed);
> + if (result)
> + goto bad_res;
> + }
If that returns an error we need to roll back the values?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-04-17 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 18:46 [PATCH] nl80211: Add set/get for frag/rts threshold and retry limits Jouni Malinen
2009-04-17 19:29 ` Johannes Berg [this message]
2009-04-17 19:38 ` Jouni Malinen
2009-04-17 19:48 ` Johannes Berg
2009-04-17 20:11 ` [PATCH v2] " Jouni Malinen
2009-04-18 12:18 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2009-04-20 12:50 [PATCH] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239996573.5110.12.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox