[PATCH] MAC80211: Remove unused MAC80211_VERBOSE_SPECT_MGMT_DEBUG.

[PATCH] MAC80211: Remove unused MAC80211_VERBOSE_SPECT_MGMT_DEBUG.

[Robert P. J. Day]

Remove this unused Kconfig variable, which Intel apparently once
promised to make use of but never did.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index f3d9ae3..ecc3faf 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -202,10 +202,3 @@ config MAC80211_DEBUG_COUNTERS
 	  and show them in debugfs.

 	  If unsure, say N.
-
-config MAC80211_VERBOSE_SPECT_MGMT_DEBUG
-	bool "Verbose Spectrum Management (IEEE 802.11h)debugging"
-	depends on MAC80211_DEBUG_MENU
-	---help---
-	  Say Y here to print out verbose Spectrum Management (IEEE 802.11h)
-	  debug messages.

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Linked In:                             http://www.linkedin.com/in/rpjday
Twitter:                                       http://twitter.com/rpjday
========================================================================

Re: [PATCH] MAC80211: Remove unused MAC80211_VERBOSE_SPECT_MGMT_DEBUG.

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

On Sat, 2009-04-18 at 09:33 -0400, Robert P. J. Day wrote:
> Remove this unused Kconfig variable, which Intel apparently once
> promised to make use of but never did.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

FWIW, this is the exact revert of the commit introducing the option:

commit 7b1e78d5052a92e95d851fbb0236a712264fe7e8
Author: Yi Zhu <yi.zhu@intel.com>
Date:   Wed Jun 18 17:53:43 2008 +0300

    mac80211: add MAC80211_VERBOSE_SPECT_MGMT_DEBUG Kconfig option
    
    The patch introduces MAC80211_VERBOSE_SPECT_MGMT_DEBUG Kconfig option to
    suppress Spectrum Management 802.11h related debug logs.
    
    Signed-off-by: Zhu Yi <yi.zhu@intel.com>
    Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>


So it's been there for over half a year. I guess we learn from that to
not take Kconfig symbols that are unused in the first place ;)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] MAC80211: Remove unused MAC80211_VERBOSE_SPECT_MGMT_DEBUG.

[Zhu Yi]

On Sat, 2009-04-18 at 21:38 +0800, Johannes Berg wrote:
> On Sat, 2009-04-18 at 09:33 -0400, Robert P. J. Day wrote:
> > Remove this unused Kconfig variable, which Intel apparently once
> > promised to make use of but never did.
> > 
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> Acked-by: Johannes Berg <johannes@sipsolutions.net>

Ack. Sorry about it!

Thanks,
-yi

> FWIW, this is the exact revert of the commit introducing the option:
> 
> commit 7b1e78d5052a92e95d851fbb0236a712264fe7e8
> Author: Yi Zhu <yi.zhu@intel.com>
> Date:   Wed Jun 18 17:53:43 2008 +0300
> 
>     mac80211: add MAC80211_VERBOSE_SPECT_MGMT_DEBUG Kconfig option
>     
>     The patch introduces MAC80211_VERBOSE_SPECT_MGMT_DEBUG Kconfig option to
>     suppress Spectrum Management 802.11h related debug logs.
>     
>     Signed-off-by: Zhu Yi <yi.zhu@intel.com>
>     Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>     Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 
> 
> So it's been there for over half a year. I guess we learn from that to
> not take Kconfig symbols that are unused in the first place ;)
> 
> johannes