From: reinette chatre <reinette.chatre@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwl3945: fix section type conflict on powerpc
Date: Wed, 22 Apr 2009 11:03:33 -0700 [thread overview]
Message-ID: <1240423413.29805.40.camel@rc-desk> (raw)
In-Reply-To: <1240414421.5198.3.camel@johannes.local>
On Wed, 2009-04-22 at 08:33 -0700, Johannes Berg wrote:
> For some reason on powerpc I get:
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>
> The function doesn't need to be exported, and unexporting fixes it,
> so I'm not thinking about what is causing it.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:53.614082341 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:55.382327490 +0200
> @@ -1413,7 +1413,6 @@ void iwl3945_rx_queue_reset(struct iwl_p
> rxq->free_count = 0;
> spin_unlock_irqrestore(&rxq->lock, flags);
> }
> -EXPORT_SYMBOL(iwl3945_rx_queue_reset);
>
> /*
> * this should be called while priv->lock is locked
>
>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Thank you
Reinette
prev parent reply other threads:[~2009-04-22 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 15:33 [PATCH] iwl3945: fix section type conflict on powerpc Johannes Berg
2009-04-22 18:03 ` reinette chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240423413.29805.40.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox