Re: [PATCH] mac80211: add driver ops wrappers

Kalle Valo
2009-04-24T05:37:53Z

Johannes Berg <johannes@sipsolutions.net> writes:

> In order to later add tracing or verifications to the driver
> calls mac80211 makes, this patch adds static inline wrappers
> for all operations.
>
> All calls are now written as
>
> drv_<op>(local, ...);
>
> instead of
>
> local->ops-><op>(&local->hw, ...);
>
> Where necessary, the wrappers also do existence checking and
> return default values as appropriate.

Also grepping is easier this way. I think this is a good change to have,
especially I'm interested of tracing driver calls. Until now I have
added debug messages to all drivers I maintain.

But I'm just concerned about the drv prefix, with very bad luck it might
create conflicts with some other component. What about using
ieee80211_drv, for example?

--
Kalle Valo