public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] libertas: fix format warning
Date: Tue, 28 Apr 2009 10:48:52 -0400	[thread overview]
Message-ID: <1240930132.25559.7.camel@localhost.localdomain> (raw)
In-Reply-To: <1240601958-7273-1-git-send-email-linville@tuxdriver.com>

On Fri, 2009-04-24 at 15:39 -0400, John W. Linville wrote:
> drivers/net/wireless/libertas/if_spi.c: In function =E2=80=98if_spi_c=
2h_data=E2=80=99:
> drivers/net/wireless/libertas/if_spi.c:733: warning: format =E2=80=98=
%u=E2=80=99 expects type =E2=80=98unsigned int=E2=80=99, but argument 4=
 has type =E2=80=98long unsigned int=E2=80=99
>=20
> Signed-off-by: John W. Linville <linville@tuxdriver.com>

Yup; since that define includes a sizeof() it'll be native pointer size=
,
not simply a uint.

Acked-by: Dan Williams <dcbw@redhat.com>

> ---
>  drivers/net/wireless/libertas/if_spi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/drivers/net/wireless/libertas/if_spi.c b/drivers/net/wir=
eless/libertas/if_spi.c
> index 97493e2..dccd01f 100644
> --- a/drivers/net/wireless/libertas/if_spi.c
> +++ b/drivers/net/wireless/libertas/if_spi.c
> @@ -731,7 +731,7 @@ static int if_spi_c2h_data(struct if_spi_card *ca=
rd)
>  		goto out;
>  	} else if (len > MRVDRV_ETH_RX_PACKET_BUFFER_SIZE) {
>  		lbs_pr_err("%s: error: card has %d bytes of data, but "
> -			   "our maximum skb size is %u\n",
> +			   "our maximum skb size is %lu\n",
>  			   __func__, len, MRVDRV_ETH_RX_PACKET_BUFFER_SIZE);
>  		err =3D -EINVAL;
>  		goto out;

--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2009-04-28 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24 19:39 [PATCH] libertas: fix format warning John W. Linville
2009-04-24 19:39 ` [PATCH] wireless: remove some (bogus?) 'may be used uninitialized' warnings John W. Linville
2009-04-28 14:48 ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240930132.25559.7.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox