Re: wireless: remove some (bogus?) 'may be used uninitialized' warnings

Re: wireless: remove some (bogus?) 'may be used uninitialized' warnings

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

Hi John,

commit aa61eccbbd46faa89a7ebb06e642779a8fffa2c2
Author: John W. Linville <linville@tuxdriver.com>
Date:   Fri Apr 24 15:35:42 2009 -0400

    wireless: remove some (bogus?) 'may be used uninitialized' warnings
    
    net/mac80211/tx.c: In function ‘ieee80211_tx_h_select_key’:
    net/mac80211/tx.c:448: warning: ‘key’ may be used uninitialized in this function

This warning is totally _wrong_, and I would prefer you reverted this
commit because otherwise we may miss actually valid warnings when
editing those functions.

The fact that you get this warning is due to the, IMHO entirely stupid,
CONFIG_TRACE_BRANCH_PROFILING, which redefines if() as a macro. As one
would expect according to the GIGO principle [1], this causes the
compiler some problems. Can you turn that off in your config instead? :)

johannes

[1] http://en.wikipedia.org/wiki/Garbage_In,_Garbage_Out


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]