Re: [RFC] rfkill: rewrite

Ivo van Doorn
2009-03-30T17:54:11Z

On Monday 30 March 2009, Johannes Berg wrote:
> On Mon, 2009-03-30 at 10:39 -0700, Inaky Perez-Gonzalez wrote:
> > On Monday 30 March 2009, Johannes Berg wrote:
> > >
> > > * wimax
> > > -> need help, seems to report rfkill states to input device?
> > > don't understand
> >
> > Not really.
> >
> > What it does is if the device exposes a hw rfkill key, export that
> > key as an input device, as well as using it to report the state
> > change.
> >
> > So there are three main entry points:
> >
> > wimax_report_rfkill_hw() -- device driver report to stack
> >
> > device reports a change in the hw rfkill key; switch the radio to
> > whichever state AND report a key event through the input layer
>
> But reporting the key through the input layer is wrong, afaict.

Why because it combines it with switching the radio?
In rt2x00 all key events are going through the input layer as well,
because it has no influence on the radio state of the device.
(In other words, you can still happily send and receive all
the data you want regardless of the key state).

Ivo