Re: [RFC] rfkill: rewrite

Johannes Berg
2009-03-30T09:57:29Z

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On Mon, 2009-03-30 at 11:54 +0200, Michael Buesch wrote:
> On Monday 30 March 2009 11:06:27 Johannes Berg wrote:
> > On Sun, 2009-03-29 at 19:53 +0200, Johannes Berg wrote:
> > > This patch completely rewrites the rfkill core to address
> > > the following deficiencies:
> > >
> > > * all rfkill drivers need to implement polling where necessary
> > > rather than having one central implementation
> >
> > One thing I was wondering about -- should we just implement polling via
> > a single work struct that iterates all those rfkill drivers that need
> > polling? I've given them each an own right now, but that seems
> > unnecessary.
>
> If it doesn't add new locking problems (global locks, etc...) that'd be OK.

Hm, indeed, it probably would -- rfkill_register needs a global lock
while being called from the driver, and the polling would need the same
lock while calling into the driver.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]