Re: [RFC] rfkill: rewrite

Henrique de Moraes Holschuh
2009-03-30T20:52:19Z

On Mon, 30 Mar 2009, Johannes Berg wrote:
> On Mon, 2009-03-30 at 10:39 -0700, Inaky Perez-Gonzalez wrote:
> > On Monday 30 March 2009, Johannes Berg wrote:
> > >
> > > * wimax
> > > -> need help, seems to report rfkill states to input device?
> > > don't understand
> >
> > Not really.
> >
> > What it does is if the device exposes a hw rfkill key, export that
> > key as an input device, as well as using it to report the state
> > change.
> >
> > So there are three main entry points:
> >
> > wimax_report_rfkill_hw() -- device driver report to stack
> >
> > device reports a change in the hw rfkill key; switch the radio to
> > whichever state AND report a key event through the input layer
>
> But reporting the key through the input layer is wrong, afaict.

Reporting the key through the input layer is correct if, and _only_ if, it
is REALLY a button/key, AND nothing else is doing it.

It is NOT to be done in anything that could be, for example, an input pin
that is tied to a GPIO output in the embedded controller of a laptop that
will be driven by a platform driver.

And if it could be both and you can't be certain, you need dmi whitelisting
or a module parameter to know which one. And default to NOT issuing input
events.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh