From: reinette chatre <reinette.chatre@intel.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: iwlwifi: remove EXPORT_SYMBOL for static symbol
Date: Thu, 30 Apr 2009 11:33:10 -0700 [thread overview]
Message-ID: <1241116390.10498.50.camel@rc-desk> (raw)
In-Reply-To: <m24ow6xd9y.fsf@igel.home>
Andreas,
On Thu, 2009-04-30 at 10:27 -0700, Andreas Schwab wrote:
>
> reinette chatre
> <reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
>
> > On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote:
> >> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
> >> this build error:
> >>
> >> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> >>
> >> Signed-off-by: Andreas Schwab <schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
> >> ---
> >> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
> >
> >>From which repo is this commit id?
>
> That's from davem/net-2.6 or linville/wireless-2.6.git
Thanks. Even though this patch obsoletes
6269b731560d69c5eaa929909891edec39496d71 it still makes sense to have
that patch in the repo as it removes another unnecessary EXPORT_SYMBOL.
I would thus prefer that both patches are included.
Reinette
next prev parent reply other threads:[~2009-04-30 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 7:58 iwlwifi: remove EXPORT_SYMBOL for static symbol Andreas Schwab
2009-04-30 8:09 ` Johannes Berg
2009-04-30 8:20 ` Andreas Schwab
2009-04-30 8:36 ` Johannes Berg
2009-04-30 17:21 ` reinette chatre
2009-04-30 17:27 ` Andreas Schwab
2009-04-30 18:33 ` reinette chatre [this message]
2009-04-30 18:33 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241116390.10498.50.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).