Re: [PATCH] add basic support for parsing country information element

Marcel Holtmann
2009-05-04T15:52:56Z

Hi Johannes,

> > I've committed everything, and am doing some minor cleanups. I also
> > noticed we don't validate everything as good as we should so I'm adding
> > some support for that.
>
> I've done that now, and pushed it out, but I think the RSN IE printing
> you added (and I renamed to print_rsn_ie) is missing some input length
> validation, could you take a look at that please? In particular it takes
> the count from the IE, but doesn't verify it fits, I think?

I can have a look at it since it is by no means perfect, but at least we
know have something that allows us to not bother with iwlist.

Btw. I named it WPA2 on purpose since not everybody using iw will
understand that it is actually named RSN. In the end it is your call,
just to let you know why I did it. One of my first patches actually did
use RSN in it :)

Regards

Marcel