Re: [PATCH] add basic support for parsing country information element

Marcel Holtmann
2009-05-04T16:09:32Z

Hi Johannes,

> > > I've done that now, and pushed it out, but I think the RSN IE printing
> > > you added (and I renamed to print_rsn_ie) is missing some input length
> > > validation, could you take a look at that please? In particular it takes
> > > the count from the IE, but doesn't verify it fits, I think?
> >
> > I can have a look at it since it is by no means perfect, but at least we
> > know have something that allows us to not bother with iwlist.
>
> Certainly. I just don't want to have it crash on an AP that advertises
> completely bogus information :)

if nobody beats me to it, then I will fix this. Just have to deal with
some other stuff first.

> > Btw. I named it WPA2 on purpose since not everybody using iw will
> > understand that it is actually named RSN. In the end it is your call,
> > just to let you know why I did it. One of my first patches actually did
> > use RSN in it :)
>
> :)
> I was going to call it RSN/WPA2 but that was too long for nice
> displaying. Now that I think about it though, I think RSN is more
> correct because WPA2 certification doesn't include any 11w things which
> this will include. I suspect something like WPA3 will be done for that.
> Who knows :)

tried the RSN/WPA2 too, but it is too long :)

On a different note, what is your preferred coding style for loops?

for (i = 0; i < len; i++) {

or

for(i=0; i<len-3; i++)

I was using the latter one since I assumed that is what you want (it is
not my preferred one). Then I realized that you are using both or that
something slipped in. Do you want me to send a patch to fix this?

Regards

Marcel