From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: pid, fix memory corruption
Date: Mon, 04 May 2009 18:07:17 +0200 [thread overview]
Message-ID: <1241453238.8683.52.camel@johannes.local> (raw)
In-Reply-To: <1241453096-8517-2-git-send-email-jirislaby@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
On Mon, 2009-05-04 at 18:04 +0200, Jiri Slaby wrote:
> + for (i = 0; i < IEEE80211_NUM_BANDS; i++) {
> + sband = hw->wiphy->bands[i];
> + if (sband->n_bitrates > max_rates)
> + max_rates = sband->n_bitrates;
> + }
> +
> /* We can safely assume that sband won't change unless we get
> * reinitialized. */
> - rinfo = kmalloc(sizeof(*rinfo) * sband->n_bitrates, GFP_ATOMIC);
> + rinfo = kmalloc(sizeof(*rinfo) * max_rates, GFP_ATOMIC);
I suppose you should remove the comment...
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-05-04 16:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 16:04 [PATCH 1/2] mac80211: minstrel, fix memory corruption Jiri Slaby
2009-05-04 16:04 ` [PATCH 2/2] mac80211: pid, " Jiri Slaby
2009-05-04 16:07 ` Johannes Berg [this message]
2009-05-04 16:10 ` [PATCH v2 " Jiri Slaby
2009-05-04 16:17 ` [PATCH 1/2] mac80211: minstrel, " Bob Copeland
2009-05-04 16:40 ` Felix Fietkau
2009-05-04 18:38 ` Luis R. Rodriguez
2009-05-04 18:41 ` Jiri Slaby
2009-05-15 18:21 ` Heinz Diehl
2009-05-15 18:33 ` John W. Linville
2009-05-15 18:49 ` Linus Torvalds
2009-05-15 18:53 ` John W. Linville
2009-05-15 21:25 ` Marcel Holtmann
2009-05-15 21:32 ` Linus Torvalds
2009-05-15 18:40 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241453238.8683.52.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).