From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, Jouni Malinen <j@w1.fi>
Subject: [PATCH v2] wext: remove seq_start/stop sparse annotations
Date: Tue, 12 May 2009 08:36:43 +0200 [thread overview]
Message-ID: <1242110203.3873.52.camel@johannes.local> (raw)
In-Reply-To: <1242109130.3873.49.camel@johannes.local>
Even though they are true, they cause sparse to complain
because it doesn't see the __acquires(dev_base_lock) on
dev_seq_start() because it is only added to the function
in net/core/dev.c, not the header file. To keep track of
the nesting correctly we should probably annotate those
functions publically, but for now let's just remove the
annotation I added to wext.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
Umm, now with subject.
net/wireless/wext.c | 2 --
1 file changed, 2 deletions(-)
--- wireless-testing.orig/net/wireless/wext.c 2009-05-12 08:12:23.000000000 +0200
+++ wireless-testing/net/wireless/wext.c 2009-05-12 08:13:16.000000000 +0200
@@ -650,14 +650,12 @@ static int wireless_seq_show(struct seq_
}
static void *wireless_dev_seq_start(struct seq_file *seq, loff_t *pos)
- __acquires(dev_base_lock)
{
rtnl_lock();
return dev_seq_start(seq, pos);
}
static void wireless_dev_seq_stop(struct seq_file *seq, void *v)
- __releases(dev_base_lock)
{
dev_seq_stop(seq, v);
rtnl_unlock();
prev parent reply other threads:[~2009-05-12 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 6:18 [PATCH] Johannes Berg
2009-05-12 6:36 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242110203.3873.52.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox