Re: [PATCH] cfg80211: fix a couple of bugs with key ioctls

Johannes Berg
2009-05-12T19:21:09Z

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

On Tue, 2009-05-12 at 20:05 +0100, Hin-Tak Leung wrote:

> I tried this, NM/wpa_suplicany still doesn't work, but if I shut those
> down and do it the old fashioned iwconfig way, I can get
> connectivity...

That's odd. Are you getting "connectivity" with a WEP network then?

> the last chunk looks a bit funny - '(idx < 4 || idx >
> 5)' is just '(idx != 4)' so why it isn't written simplier as such?
> also the idx < 0 maybe <1 ?

No? <4 || >5 is anything but 4 and 5. And idx<0 certainly is correct too
there.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]