Re: [RFT v9] rfkill: rewrite

Dan Williams
2009-05-12T17:58:48Z

On Tue, 2009-05-12 at 13:26 -0400, Will Keaney wrote:
> Johannes Berg wrote:
> > This patch completely rewrites the rfkill core to address
> > the following deficiencies:
> >
> > * all rfkill drivers need to implement polling where necessary
> > rather than having one central implementation
> >
> > * updating the rfkill state cannot be done from arbitrary
> > contexts, forcing drivers to use schedule_work and requiring
> > lots of code
> >
> > * rfkill drivers need to keep track of soft/hard blocked
> > internally -- the core should do this
> >
> > * the rfkill API has many unexpected quirks, for example being
> > asymmetric wrt. alloc/free and register/unregister
> >
> > * rfkill can call back into a driver from within a function the
> > driver called -- this is prone to deadlocks and generally
> > should be avoided
> >
> > * rfkill-input pointlessly is a separate module
> >
> Please leave rfkill-input available as a module, at least until the bug
> I reported in my previous e-mail 'Soft Lockup With rfkill_input and
> thinkpad_acpi' is resolved. Otherwise it will render Thinkpads, and
> possibly other systems, unusable with rfkill enabled.

The problem gets fixed where the problem is at... if the actual root
cause is in the rfkill rewrite, then maybe Johannes should take a look.
If the actual root cause is a bug in thinkpad-acpi, then it shouldn't
block the rfkill rewrite, but should be fixed in thinkpad-acpi.

Dan