From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@web.de>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: ar9170 deadlock report
Date: Fri, 15 May 2009 13:25:59 +0200 [thread overview]
Message-ID: <1242386759.5799.50.camel@johannes.local> (raw)
In-Reply-To: <200905151318.06411.chunkeey@web.de>
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
On Fri, 2009-05-15 at 13:18 +0200, Christian Lamparter wrote:
> > Don't cancel a work under a lock that it needs!
> >
> > johannes
> >
> do you have the module this time?
Yes, why? The bug is trivial:
mutex_lock(&ar->mutex);
cancel_delayed_work_sync(&ar->tx_status_janitor);
cancel_work_sync(&ar->filter_config_work);
cancel_work_sync(&ar->beacon_work);
vs.
static void ar9170_tx_status_janitor(struct work_struct *work)
{
...
mutex_lock(&ar->mutex);
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-05-15 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 10:50 ar9170 deadlock report Johannes Berg
2009-05-15 11:18 ` Christian Lamparter
2009-05-15 11:25 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242386759.5799.50.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox