From: Dan Williams <dcbw@redhat.com>
To: andrey@cozybit.com
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: libertas: fix GSPI card event handling
Date: Wed, 20 May 2009 18:18:10 -0400 [thread overview]
Message-ID: <1242857890.7048.22.camel@localhost.localdomain> (raw)
In-Reply-To: <4a134cbd.1ebc720a.4cee.ffffc1c3@mx.google.com>
On Tue, 2009-05-19 at 17:20 -0700, andrey@cozybit.com wrote:
> The GPSI interface driver does not re-enable the Card Event Interrupt, which
> causes problems after a card event (for example: link-loss) comes in. This
> can lead, for example, to the card failing to re-associate. This patch
> ensures that we re-enable the Card Event Interrupt when we handle card events.
>
> Signed-off-by: Andrey Yurovsky <andrey@cozybit.com>
Where does that bit ever get disabled? Is that done by the firmware
after it sends the interrupt? I don't think I quite understand what's
going on here...
Dan
> diff --git a/drivers/net/wireless/libertas/if_spi.c b/drivers/net/wireless/libertas/if_spi.c
> index dccd01f..5fa55fe 100644
> --- a/drivers/net/wireless/libertas/if_spi.c
> +++ b/drivers/net/wireless/libertas/if_spi.c
> @@ -814,6 +814,13 @@ static void if_spi_e2h(struct if_spi_card *card)
> if (err)
> goto out;
>
> + /* re-enable the card event interrupt */
> + spu_write_u16(card, IF_SPI_HOST_INT_STATUS_REG,
> + ~IF_SPI_HICU_CARD_EVENT);
> +
> + /* generate a card interrupt */
> + spu_write_u16(card, IF_SPI_CARD_INT_CAUSE_REG, IF_SPI_CIC_HOST_EVENT);
> +
> spin_lock_irqsave(&priv->driver_lock, flags);
> lbs_queue_event(priv, cause & 0xff);
> spin_unlock_irqrestore(&priv->driver_lock, flags);
>
>
next prev parent reply other threads:[~2009-05-20 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 0:20 libertas: fix GSPI card event handling andrey
2009-05-20 22:18 ` Dan Williams [this message]
2009-05-20 22:28 ` Andrey Yurovsky
2009-05-20 22:29 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242857890.7048.22.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=andrey@cozybit.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).