From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: rfkill v9: fixes and thinkpad-acpi conversion
Date: Thu, 21 May 2009 00:04:16 -0300 [thread overview]
Message-ID: <1242875059-9627-1-git-send-email-hmh@hmh.eng.br> (raw)
John,
Here are two patches for the rfkill core rewrite, plus the thinkpad-acpi
conversion.
Just fold them into your latest rfkill rewrite patch.
HOWEVER, the thing doesn't work right. Now, I am pretty sure I might have
done something wrong somewhere in the thinkpad-acpi conversion (for
example: the UWB switch never registers with its hw-block state right, but
all others do), and I would appreciate if you could look it over and tell
me what I am doing that upsets the core.
The core might have some bugs left, too. It seems to ignore set_sw_state
changes, I can't see it reflected on rfkill/state, and it is _not_ because
it is trying to set it back to whatever it wanted properly (or I'd get
calls to the set_block hook). Maybe it is something in my thinkpad-acpi
conversion, though.
Anyway, the core needs proper coverage testing of its full functionality
before it can be merged in mainline. Just like you found that the old core
never worked right for LEDs, the new rewrite was not processing any KEY_*
input events, which is a quite important functionality...
Regardless of that, the rewrite is likely good enough for wireless-testing,
now. At least it will compile cleanly now that thinkpad-acpi is converted.
But PLEASE don't let it go to mainline before:
1. It is gets good coverage testing, and
2. Write support to let userspace change the switch status is implemented.
It is a show-stopper for platform drivers.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next reply other threads:[~2009-05-21 3:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 3:04 Henrique de Moraes Holschuh [this message]
2009-05-21 3:04 ` [PATCH 1/3] rfkill: add missing static Henrique de Moraes Holschuh
2009-05-21 3:04 ` [PATCH 2/3] rfkill: fix input event handling in rfkill conversion Henrique de Moraes Holschuh
2009-05-21 3:04 ` [PATCH 3/3] thinkpad-acpi: convert to new rfkill API Henrique de Moraes Holschuh
2009-05-21 10:52 ` rfkill v9: fixes and thinkpad-acpi conversion Johannes Berg
2009-05-21 19:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242875059-9627-1-git-send-email-hmh@hmh.eng.br \
--to=hmh@hmh.eng.br \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox