From: Johannes Berg <johannes@sipsolutions.net>
To: Zhu Yi <yi.zhu@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Samuel Ortiz <samuel.ortiz@intel.com>
Subject: Re: [PATCH 1/2 V2] wireless: move some utility functions from mac80211 to cfg80211
Date: Thu, 21 May 2009 15:41:36 +0200 [thread overview]
Message-ID: <1242913296.4212.3.camel@johannes.local> (raw)
In-Reply-To: <1242912045-554-1-git-send-email-yi.zhu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
On Thu, 2009-05-21 at 21:20 +0800, Zhu Yi wrote:
> /**
> - * enum ieee80211_key_len - key length
> - * @LEN_WEP40: WEP 5-byte long key
> - * @LEN_WEP104: WEP 13-byte long key
> - */
> -enum ieee80211_key_len {
> - LEN_WEP40 = 5,
> - LEN_WEP104 = 13,
> -};
You don't seem to be updating the users of these? I have no problem with
keeping them here either, but as-is this would break ath5k/9k/ar9170,
b43 and rt2x00 compilation afaict.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-05-21 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 13:20 [PATCH 1/2 V2] wireless: move some utility functions from mac80211 to cfg80211 Zhu Yi
2009-05-21 13:20 ` [PATCH 2/2 V2] iwmc3200wifi: Add new Intel Wireless Multicomm 802.11 driver Zhu Yi
2009-05-21 13:41 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242913296.4212.3.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=samuel.ortiz@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox