From: Dan Williams <dcbw@redhat.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 5/5] libertas: fix WPA adhoc network creation
Date: Fri, 22 May 2009 20:16:01 -0400 [thread overview]
Message-ID: <1243037761.2495.15.camel@localhost.localdomain> (raw)
In-Reply-To: <1243037398.2495.14.camel@localhost.localdomain>
On Fri, 2009-05-22 at 20:09 -0400, Dan Williams wrote:
> Oddly enough, the firmware's JOIN/START commands don't appear to have
> any facility for setting custom IEs, thus the started adhoc network
> doesn't advertise its WPA capability in the beacon. Whee!
Turns out v10 firmware now has this capability, but v9 and lower do not.
Just for the record.
Dan
> Signed-off-by: Dan Williams <dcbw@redhat.com>
>
> diff --git a/drivers/net/wireless/libertas/assoc.c b/drivers/net/wireless/libertas/assoc.c
> index cb73720..b9b3741 100644
> --- a/drivers/net/wireless/libertas/assoc.c
> +++ b/drivers/net/wireless/libertas/assoc.c
> @@ -711,11 +711,13 @@ static int lbs_adhoc_start(struct lbs_private *priv,
>
> /* set capability info */
> tmpcap = WLAN_CAPABILITY_IBSS;
> - if (assoc_req->secinfo.wep_enabled) {
> - lbs_deb_join("ADHOC_START: WEP enabled, setting privacy on\n");
> + if (assoc_req->secinfo.wep_enabled ||
> + assoc_req->secinfo.WPAenabled ||
> + assoc_req->secinfo.WPA2enabled) {
> + lbs_deb_join("ADHOC_START: WEP/WPA enabled, privacy on\n");
> tmpcap |= WLAN_CAPABILITY_PRIVACY;
> } else
> - lbs_deb_join("ADHOC_START: WEP disabled, setting privacy off\n");
> + lbs_deb_join("ADHOC_START: WEP disabled, privacy off\n");
>
> cmd.capability = cpu_to_le16(tmpcap);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-05-23 0:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 0:09 [PATCH 5/5] libertas: fix WPA adhoc network creation Dan Williams
2009-05-23 0:16 ` Dan Williams [this message]
2009-05-23 8:24 ` Johannes Berg
2009-05-24 13:19 ` Dan Williams
2009-05-24 17:24 ` Johannes Berg
2009-05-25 7:51 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243037761.2495.15.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).