Re: [PATCH 2/4] rndis_wlan: explain bits used in key setup code.

[Dan Williams <dcbw@redhat.com>]

On Sat, 2009-05-23 at 09:56 +0300, Jussi Kivilinna wrote:
> Quoting "Dan Williams" <dcbw@redhat.com>:
> 
> > On Fri, 2009-05-22 at 17:40 +0300, Jussi Kivilinna wrote:
> >> Driver uses some unnamed bits to control encryption setup. Move these to
> >> enumerations with proper names explaining their meaning.
> >>
> >> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
> >> ---
> >>
> >>  drivers/net/wireless/rndis_wlan.c |   23 ++++++++++++++++++-----
> >>  1 files changed, 18 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/rndis_wlan.c  
> >> b/drivers/net/wireless/rndis_wlan.c
> >> index f9b0a35..8609d28 100644
> >> --- a/drivers/net/wireless/rndis_wlan.c
> >> +++ b/drivers/net/wireless/rndis_wlan.c
> >> @@ -196,6 +196,18 @@ enum ndis_80211_priv_filter {
> >>  	ndis_80211_priv_8021x_wep
> >>  };
> >>
> >> +enum ndis_80211_addkey_bits {
> >> +	ndis_80211_addkey_8021x_auth = cpu_to_le32(1 << 28),
> >> +	ndis_80211_addkey_set_init_recv_seq = cpu_to_le32(1 << 29),
> >> +	ndis_80211_addkey_pairwise_key = cpu_to_le32(1 << 30),
> >> +	ndis_80211_addkey_transmit_key = cpu_to_le32(1 << 31),
> >> +};
> >
> > Enums and defines are usually capitalized in Linux, ie
> > NDIS_80211_ADDKEY_8021X_AUTH, so that they can be separated from
> > non-constant stuff and from function names.  Makes the code more
> > readable.  Any chance you'd mind doing that in this patch since you're
> > touching these bits?
> >
> > Dan
> 
> All the ndis_80211_* enums in rndis_wlan.c are lower case now, so I'd  
> keep it consistent here and change all the enums upper case in  
> separate patch.

Ok, sounds fine.

Dan