From: Marcel Holtmann <holtmann@linux.intel.com>
To: Zhu Yi <yi.zhu@intel.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Ortiz, Samuel" <samuel.ortiz@intel.com>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH 2/3] iwmc3200wifi: shrink calibration lmac name
Date: Tue, 26 May 2009 08:33:03 +0200 [thread overview]
Message-ID: <1243319583.30938.2.camel@localhost.localdomain> (raw)
In-Reply-To: <1243317777.3623.19.camel@debian>
Hi Yi,
> > > Firmware names can not be longer than 30 characters, and
> > > iwmc3200wifi-lmac-calib-sdio.bin is too long.
> > > Renaming it to iwmc3200wifi-calib-sdio.bin.
> >
> > hold on with this one. This limit should _NOT_ exist. Is this an issue
> > in the driver model?
>
> It should be FW_LOADER framework implementation limitation.
>
> request_firmware()
> -> fw_setup_device()
> -> fw_register_device()
>
> fw_register_device()
> {
> ...
> strlcpy(fw_priv->fw_id, fw_name, FIRMWARE_NAME_MAX);
> ...
> }
>
> FIRMWARE_NAME_MAX is defined 30 at this time.
I think we need to fix this. Especially since all the other name length
limits in the driver model are gone.
Regards
Marcel
next prev parent reply other threads:[~2009-05-26 6:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 3:10 [PATCH 1/3] iwmc3200wifi: fix fragmentation threshold setting Zhu Yi
2009-05-26 3:10 ` [PATCH 2/3] iwmc3200wifi: shrink calibration lmac name Zhu Yi
2009-05-26 3:10 ` [PATCH 3/3] iwmc3200wifi: fix link error when CFG80211 is not selected Zhu Yi
2009-05-26 5:42 ` David Miller
2009-05-26 4:43 ` [PATCH 2/3] iwmc3200wifi: shrink calibration lmac name Marcel Holtmann
2009-05-26 6:02 ` Zhu Yi
2009-05-26 6:33 ` Marcel Holtmann [this message]
2009-05-26 6:36 ` Christoph Hellwig
2009-05-26 6:36 ` Zhu Yi
2009-05-26 6:41 ` Marcel Holtmann
2009-05-26 6:47 ` Zhu Yi
2009-05-26 8:51 ` Marcel Holtmann
2009-05-26 11:04 ` Samuel Ortiz
2009-05-26 11:06 ` Kay Sievers
2009-05-26 14:03 ` Samuel Ortiz
2009-05-26 6:04 ` David Miller
2009-06-01 18:29 ` John W. Linville
2009-06-02 7:52 ` Zhu Yi
2009-06-02 8:09 ` Samuel Ortiz
2009-06-02 7:54 ` Samuel Ortiz
2009-06-02 8:02 ` Marcel Holtmann
2009-06-02 8:24 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243319583.30938.2.camel@localhost.localdomain \
--to=holtmann@linux.intel.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=samuel.ortiz@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).