Linux wireless drivers development
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Marcel Holtmann <holtmann@linux.intel.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Ortiz, Samuel" <samuel.ortiz@intel.com>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH 2/3] iwmc3200wifi: shrink calibration lmac name
Date: Tue, 26 May 2009 14:47:34 +0800	[thread overview]
Message-ID: <1243320454.3623.35.camel@debian> (raw)
In-Reply-To: <1243319583.30938.2.camel@localhost.localdomain>

On Tue, 2009-05-26 at 14:33 +0800, Marcel Holtmann wrote:
> > FIRMWARE_NAME_MAX is defined 30 at this time.
> 
> I think we need to fix this. Especially since all the other name
> length limits in the driver model are gone.

I agree. Should we fix this by simply increasing FIRMWARE_NAME_MAX to
some acceptable length (what should it be? btw) or there are other
better ideas?

Anyway, I think whatever how we change FW_LOADER, this patch should
still go. Because the "lmac" string doesn't make any sense in this file
name due to calibration is only done in LMAC.

Thanks,
-yi


  parent reply	other threads:[~2009-05-26  6:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26  3:10 [PATCH 1/3] iwmc3200wifi: fix fragmentation threshold setting Zhu Yi
2009-05-26  3:10 ` [PATCH 2/3] iwmc3200wifi: shrink calibration lmac name Zhu Yi
2009-05-26  3:10   ` [PATCH 3/3] iwmc3200wifi: fix link error when CFG80211 is not selected Zhu Yi
2009-05-26  5:42     ` David Miller
2009-05-26  4:43   ` [PATCH 2/3] iwmc3200wifi: shrink calibration lmac name Marcel Holtmann
2009-05-26  6:02     ` Zhu Yi
2009-05-26  6:33       ` Marcel Holtmann
2009-05-26  6:36         ` Christoph Hellwig
2009-05-26  6:36           ` Zhu Yi
2009-05-26  6:41           ` Marcel Holtmann
2009-05-26  6:47         ` Zhu Yi [this message]
2009-05-26  8:51           ` Marcel Holtmann
2009-05-26 11:04             ` Samuel Ortiz
2009-05-26 11:06               ` Kay Sievers
2009-05-26 14:03                 ` Samuel Ortiz
2009-05-26  6:04     ` David Miller
2009-06-01 18:29   ` John W. Linville
2009-06-02  7:52     ` Zhu Yi
2009-06-02  8:09       ` Samuel Ortiz
2009-06-02  7:54     ` Samuel Ortiz
2009-06-02  8:02       ` Marcel Holtmann
2009-06-02  8:24         ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243320454.3623.35.camel@debian \
    --to=yi.zhu@intel.com \
    --cc=holtmann@linux.intel.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=samuel.ortiz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox