Re: [PATCH 2/3] iwmc3200wifi: shrink calibration lmac name

[Marcel Holtmann <holtmann@linux.intel.com>]

Hi Yi,

> > > FIRMWARE_NAME_MAX is defined 30 at this time.
> > 
> > I think we need to fix this. Especially since all the other name
> > length limits in the driver model are gone.
> 
> I agree. Should we fix this by simply increasing FIRMWARE_NAME_MAX to
> some acceptable length (what should it be? btw) or there are other
> better ideas?

I think just increasing the length of the static array is bad. Can we
just not allocated the needed length for the firmware filename?

> Anyway, I think whatever how we change FW_LOADER, this patch should
> still go. Because the "lmac" string doesn't make any sense in this file
> name due to calibration is only done in LMAC.

If you think that the lmac string is pointless anyway, then that is
fine. Changing the name, because of a FW_LOADER limitation should not be
done of course.

Regards

Marcel