From: Jouni Malinen <jouni.malinen@atheros.com>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k: Add sanity check for beacon_int in adhoc/mesh case
Date: Mon, 1 Jun 2009 17:05:35 +0300 [thread overview]
Message-ID: <1243865135.1930.2.camel@jm-desktop> (raw)
In-Reply-To: <87skikt72k.fsf@litku.valot.fi>
On Mon, 2009-06-01 at 06:30 -0700, Kalle Valo wrote:
> Jouni Malinen <jouni.malinen@atheros.com> writes:
>
> > + /*
> > + * It looks like mac80211 may end up using beacon interval of zero in
> > + * some cases (at least for mesh point). Avoid getting into an
> > + * infinite loop by using a bit safer value instead..
> > + */
> > + if (intval == 0)
> > + intval = 100;
>
> Maybe a big fat warning here would help with debugging the issue?
If we agree that this should never happen, such a thing could be added.
Though, it would probably be better to place that in mac80211 so that it
would catch the issue with any driver. The beacon_int=0 notification is
not really in any way specific to ath9k; only this workaround for driver
behavior is.
- Jouni
next prev parent reply other threads:[~2009-06-01 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 16:25 [PATCH] ath9k: Add sanity check for beacon_int in adhoc/mesh case Jouni Malinen
2009-06-01 13:30 ` Kalle Valo
2009-06-01 14:05 ` Jouni Malinen [this message]
2009-06-01 14:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243865135.1930.2.camel@jm-desktop \
--to=jouni.malinen@atheros.com \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).