From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: <linville@tuxdriver.com>
Cc: <linux-wireless@vger.kernel.org>, <Luis.Rodriguez@atheros.com>,
<Jouni.Malinen@atheros.com>, <ath9k-devel@lists.ath9k.org>
Subject: [PATCH] ath9k: Remove modparam 'debug'
Date: Tue, 2 Jun 2009 19:28:56 +0530 [thread overview]
Message-ID: <1243951136-4033-2-git-send-email-vasanth@atheros.com> (raw)
In-Reply-To: <1243951136-4033-1-git-send-email-vasanth@atheros.com>
Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
---
drivers/net/wireless/ath/ath9k/Kconfig | 4 ++--
drivers/net/wireless/ath/ath9k/debug.c | 5 +----
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index 0ed1ac3..a5ab53f 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -17,8 +17,8 @@ config ATH9K_DEBUG
depends on ATH9K
---help---
Say Y, if you need ath9k to display debug messages.
- Pass the debug mask as a module parameter:
+ Pass the debug mask through debugfs interface:
- modprobe ath9k debug=0x00002000
+ echo <debug mask> > /<debugfsroot>/ath9k/phyX/debug
Look in ath9k/core.h for possible debug masks
diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c
index 6d20725..a4c0c7a 100644
--- a/drivers/net/wireless/ath/ath9k/debug.c
+++ b/drivers/net/wireless/ath/ath9k/debug.c
@@ -18,9 +18,6 @@
#include "ath9k.h"
-static unsigned int ath9k_debug = DBG_DEFAULT;
-module_param_named(debug, ath9k_debug, uint, 0);
-
static struct dentry *ath9k_debugfs_root;
void DPRINTF(struct ath_softc *sc, int dbg_mask, const char *fmt, ...)
@@ -489,7 +486,7 @@ static const struct file_operations fops_wiphy = {
int ath9k_init_debug(struct ath_softc *sc)
{
- sc->debug.debug_mask = ath9k_debug;
+ sc->debug.debug_mask = DBG_DEFAULT;
if (!ath9k_debugfs_root)
return -ENOENT;
--
1.5.5.1
next prev parent reply other threads:[~2009-06-02 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 13:58 [PATCH] ath9k: Fix write callback of 'debug' which configures debug mask Vasanthakumar Thiagarajan
2009-06-02 13:58 ` Vasanthakumar Thiagarajan [this message]
2009-06-02 16:43 ` [PATCH] ath9k: Remove modparam 'debug' Luis R. Rodriguez
2009-06-03 4:57 ` Vasanthakumar Thiagarajan
2009-06-03 5:00 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243951136-4033-2-git-send-email-vasanth@atheros.com \
--to=vasanth@atheros.com \
--cc=Jouni.Malinen@atheros.com \
--cc=Luis.Rodriguez@atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).