From: castet.matthieu@free.fr
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Michael Buesch <mb@bu3sch.de>,
linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de,
Matthieu CASTET <castet.matthieu@free.fr>
Subject: Re: [PATCH] b43: Fix possible unaligned u32 access
Date: Fri, 05 Jun 2009 17:03:57 +0200 [thread overview]
Message-ID: <1244214237.4a2933dda6634@imp.free.fr> (raw)
In-Reply-To: <20090605122503.GA2791@tuxdriver.com>
Quoting "John W. Linville" <linville@tuxdriver.com>:
> On Thu, Jun 04, 2009 at 11:18:33PM +0200, Michael Buesch wrote:
> > From: Matthieu CASTET <castet.matthieu@free.fr>
> >
> > Fix possible unaligned u32 access in b43_generate_plcp_hdr().
> > Unaligned data is read/write with a u32 pointer instead of using the
> > packed structure. Some versions of gcc ignore the "packed" attribute, if
> the
> > structure element is accessed through a local pointer.
> >
> > Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> That seems pretty brain-dead...can you cite a source for this
> information?
The test I did with the attached test case in the first post.
I don't see why gcc should propagate packed structure info to assignment.
That will be impossible to handle (think of passing it to function parameter).
> The patch seems like a no-op...
At least the code produced on mips is different.
Matthieu
next prev parent reply other threads:[~2009-06-05 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 21:18 [PATCH] b43: Fix possible unaligned u32 access Michael Buesch
2009-06-05 12:25 ` John W. Linville
2009-06-05 15:03 ` castet.matthieu [this message]
2009-06-05 18:53 ` John W. Linville
2009-06-05 19:08 ` John W. Linville
2009-06-05 17:29 ` Michael Buesch
2009-06-05 18:50 ` John W. Linville
2009-06-05 19:03 ` Michael Buesch
2009-06-06 1:03 ` David Miller
2009-06-06 1:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244214237.4a2933dda6634@imp.free.fr \
--to=castet.matthieu@free.fr \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).