From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Reinette Chatre <reinette.chatre@intel.com>
Subject: [PATCH] sony: fix rfkill code
Date: Sun, 07 Jun 2009 21:57:08 +0200 [thread overview]
Message-ID: <1244404628.12956.16.camel@johannes.local> (raw)
During the rfkill conversion I added code to call
sony_nc_rfkill_set with the wrong argument, causing
a segfault Reinette reported. The compiler could not
catch that because the argument is, and needs to be,
void *.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Reported-by: Reinette Chatre <reinette.chatre@intel.com>
---
drivers/platform/x86/sony-laptop.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- wireless-testing.orig/drivers/platform/x86/sony-laptop.c 2009-06-07 21:26:30.000000000 +0200
+++ wireless-testing/drivers/platform/x86/sony-laptop.c 2009-06-07 21:49:53.000000000 +0200
@@ -1135,8 +1135,7 @@ static void sony_nc_rfkill_update()
if (hwblock) {
if (rfkill_set_hw_state(sony_rfkill_devices[i], true))
- sony_nc_rfkill_set(sony_rfkill_devices[i],
- true);
+ sony_nc_rfkill_set((void *)i, true);
continue;
}
reply other threads:[~2009-06-07 19:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244404628.12956.16.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox