From: Marcel Holtmann <marcel@holtmann.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rfkill: remove input Kconfig
Date: Mon, 08 Jun 2009 02:16:49 +0200 [thread overview]
Message-ID: <1244420209.23850.111.camel@localhost.localdomain> (raw)
In-Reply-To: <1244396398.12956.12.camel@johannes.local>
Hi Johannes,
> Now that we added the ioctl, there's no need to ask
> the user to configure this. We will keept it enabled
> for now, and eventually swap the default to n, maybe
> let people configure it under EMBEDDED or so. In any
> case, there's no need to bother users with this now.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> net/rfkill/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- wireless-testing.orig/net/rfkill/Kconfig 2009-06-07 19:37:34.000000000 +0200
> +++ wireless-testing/net/rfkill/Kconfig 2009-06-07 19:37:41.000000000 +0200
> @@ -18,7 +18,7 @@ config RFKILL_LEDS
> default y
>
> config RFKILL_INPUT
> - bool "RF switch input support"
> + bool
> depends on RFKILL
> depends on INPUT = y || RFKILL = INPUT
> - default y if !EMBEDDED
> + default y
if you want this for normal setups, I totally agree that we not should
ask the user. However when in EMBEDDED, lets give them a chance to not
compile this in. Since most likely it is not needed at all.
Regards
Marcel
next prev parent reply other threads:[~2009-06-08 0:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 17:39 [PATCH] rfkill: remove input Kconfig Johannes Berg
2009-06-08 0:16 ` Marcel Holtmann [this message]
2009-06-08 6:14 ` [PATCH v2] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244420209.23850.111.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox