From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: linville@tuxdriver.com, johannes@sipsolutions.net, j@w1.fi
Cc: linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Zhu Yi <yi.zhu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
ipw3945-devel@lists.sourceforge.net
Subject: [PATCH 16/18] iwlwifi: use ieee80211_is_data(fc)
Date: Wed, 10 Jun 2009 04:19:33 -0400 [thread overview]
Message-ID: <1244621975-1238-17-git-send-email-lrodriguez@atheros.com> (raw)
In-Reply-To: <1244621975-1238-1-git-send-email-lrodriguez@atheros.com>
iwl-agn-rs.c already uses this.
Cc: Zhu Yi <yi.zhu@intel.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>
Cc: ipw3945-devel@lists.sourceforge.net
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/iwlwifi/iwl-3945-rs.c | 7 +++----
drivers/net/wireless/iwlwifi/iwl-sta.c | 5 ++---
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-3945-rs.c b/drivers/net/wireless/iwlwifi/iwl-3945-rs.c
index b23fd53..2b77692 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945-rs.c
@@ -673,7 +673,7 @@ static void rs_get_rate(void *priv_r, struct ieee80211_sta *sta,
s8 scale_action = 0;
unsigned long flags;
struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
- u16 fc;
+ __le16 fc;
u16 rate_mask = sta ? sta->supp_rates[sband->band] : 0;
s8 max_rate_idx = -1;
struct iwl_priv *priv = (struct iwl_priv *)priv_r;
@@ -682,9 +682,8 @@ static void rs_get_rate(void *priv_r, struct ieee80211_sta *sta,
IWL_DEBUG_RATE(priv, "enter\n");
/* Send management frames and NO_ACK data using lowest rate. */
- fc = le16_to_cpu(hdr->frame_control);
- if ((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA ||
- info->flags & IEEE80211_TX_CTL_NO_ACK ||
+ fc = hdr->frame_control;
+ if (!ieee80211_is_data(fc) || info->flags & IEEE80211_TX_CTL_NO_ACK ||
!sta || !priv_sta) {
IWL_DEBUG_RATE(priv, "leave: No STA priv data to update!\n");
info->control.rates[0].idx = rate_lowest_index(sband, sta);
diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c
index 2addf73..afa1633 100644
--- a/drivers/net/wireless/iwlwifi/iwl-sta.c
+++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
@@ -1044,11 +1044,10 @@ EXPORT_SYMBOL(iwl_rxon_add_station);
int iwl_get_sta_id(struct iwl_priv *priv, struct ieee80211_hdr *hdr)
{
int sta_id;
- u16 fc = le16_to_cpu(hdr->frame_control);
+ __le16 fc = hdr->frame_control;
/* If this frame is broadcast or management, use broadcast station id */
- if (((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA) ||
- is_multicast_ether_addr(hdr->addr1))
+ if (!ieee80211_is_data(fc) || is_multicast_ether_addr(hdr->addr1))
return priv->hw_params.bcast_sta_id;
switch (priv->iw_mode) {
--
1.6.0.6
next prev parent reply other threads:[~2009-06-10 8:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 8:19 [PATCH 00/18] wireless: rate cleanups Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 01/18] mac80211: disable moving between PS modes during scan Luis R. Rodriguez
2009-06-10 12:53 ` Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 02/18] mac80211: drop frames for sta with no valid rate Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 03/18] ath9k: downgrade assert in rc.c for invalid rate Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 04/18] iwlwifi: remove rs_get_rate workaround Luis R. Rodriguez
2009-06-10 19:08 ` reinette chatre
2009-06-10 20:31 ` Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 05/18] ath9k: cleanup try count for MRR in rate control Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 06/18] ath9k: remove unused min rate calculation code Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 07/18] ath9k: remove unused stepdown when looking for the next rate Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 08/18] ath9k: remove pointless wrapper ath_rc_rate_getidx() Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 09/18] ath9k: rename ath_rc_get_nextlowervalid_txrate() Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 10/18] ath9k: remove unused ath_rc_isvalid_txmask() Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 11/18] ath9k: remove ATH9K_MODE_11B Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 12/18] ath9k: remap ATH9K_MODE_* Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 13/18] ath9k: rename ath_rc_ratefind_ht() to ath_rc_get_highest_rix() Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 14/18] ath9k: remove unnecessary IEEE80211_TX_CTL_NO_ACK checks Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 15/18] mac80211: make minstrel/pid RC use ieee80211_is_data(fc) Luis R. Rodriguez
2009-06-10 8:19 ` Luis R. Rodriguez [this message]
2009-06-10 8:19 ` [PATCH 17/18] mac80211: add helper for management / no-ack frame rate decision Luis R. Rodriguez
2009-06-10 8:19 ` [PATCH 18/18] ath9k: remove rate control wraper Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244621975-1238-17-git-send-email-lrodriguez@atheros.com \
--to=lrodriguez@atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox