linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Senthil Balasubramanian <senthilkumar@atheros.com>
To: <linville@tuxdriver.com>
Cc: <jouni.malinen@atheros.com>, <luis.rodriguez@atheros.com>,
	<linux-wireless@vger.kernel.org>, <ath9k-devel@lists.ath9k.org>,
	Senthil Balasubramanian <senthilkumar@atheros.com>
Subject: [PATCH 7/7] ath9k: schedule aggregation regardless of queue depth
Date: Wed, 10 Jun 2009 21:55:32 +0530	[thread overview]
Message-ID: <1244651133-6537-8-git-send-email-senthilkumar@atheros.com> (raw)
In-Reply-To: <1244651133-6537-7-git-send-email-senthilkumar@atheros.com>

schedule aggregation regardless of queue depth. Also we shouldn't
remove holding descriptor from AC queue if it happens to be the
only descriptor.

Signed-off-by: Senthil Balasubramanian <senthilkumar@atheros.com>
---
 drivers/net/wireless/ath/ath9k/xmit.c |   15 +--------------
 1 files changed, 1 insertions(+), 14 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 328391e..eda2458 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -1113,8 +1113,7 @@ void ath_txq_schedule(struct ath_softc *sc, struct ath_txq *txq)
 		if (tid->paused)
 			continue;
 
-		if ((txq->axq_depth % 2) == 0)
-			ath_tx_sched_aggr(sc, txq, tid);
+		ath_tx_sched_aggr(sc, txq, tid);
 
 		/*
 		 * add tid to round-robin queue if more frames
@@ -1957,19 +1956,7 @@ static void ath_tx_processq(struct ath_softc *sc, struct ath_txq *txq)
 		if (bf->bf_stale) {
 			bf_held = bf;
 			if (list_is_last(&bf_held->list, &txq->axq_q)) {
-				txq->axq_link = NULL;
-				txq->axq_linkbuf = NULL;
 				spin_unlock_bh(&txq->axq_lock);
-
-				/*
-				 * The holding descriptor is the last
-				 * descriptor in queue. It's safe to remove
-				 * the last holding descriptor in BH context.
-				 */
-				spin_lock_bh(&sc->tx.txbuflock);
-				list_move_tail(&bf_held->list, &sc->tx.txbuf);
-				spin_unlock_bh(&sc->tx.txbuflock);
-
 				break;
 			} else {
 				bf = list_entry(bf_held->list.next,
-- 
1.6.0.4


  reply	other threads:[~2009-06-10 16:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 16:25 [PATCH 0/7] ATH9K bug fixes - TX hang & Signal Quality issue Senthil Balasubramanian
2009-06-10 16:25 ` [PATCH 1/7] ath9k: Manipulate and report the correct RSSI Senthil Balasubramanian
2009-06-10 16:25   ` [PATCH 2/7] ath9k: AR9285 & AR9280 INI update and minor bug fixes Senthil Balasubramanian
2009-06-10 16:25     ` [PATCH 3/7] ath9k: remove unnecessary STATION mode check Senthil Balasubramanian
2009-06-10 16:25       ` [PATCH 4/7] ath9k: stop ani when the STA gets disconnected Senthil Balasubramanian
2009-06-10 16:25         ` [PATCH 5/7] ath9k: race condition in SCANNING state check during ANI calibration Senthil Balasubramanian
2009-06-10 16:25           ` [PATCH 6/7] ath9k: Fix TX hang issue with Atheros chipsets Senthil Balasubramanian
2009-06-10 16:25             ` Senthil Balasubramanian [this message]
2009-06-10 16:25               ` [PATCH] ath9k: Fix panic when ath9k is unloaded Senthil Balasubramanian
2009-06-10 16:31                 ` Senthil Balasubramanian
2009-06-17 18:58 ` [PATCH 0/7] ATH9K bug fixes - TX hang & Signal Quality issue John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244651133-6537-8-git-send-email-senthilkumar@atheros.com \
    --to=senthilkumar@atheros.com \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=jouni.malinen@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=luis.rodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).