Re: [PATCHv2 2/4] rfkill: don't restore software blocked state on persistent devices

[Marcel Holtmann <marcel@holtmann.org>]

Hi Alan,

> The setting of the "persistent" flag is also made more explicit using
> a new rfkill_init_sw_state() function, instead of special-casing
> rfkill_set_sw_state() when it is called before registration.
> 
> Suspend is a bit of a corner case so we try to get away without adding
> another hack to rfkill-input - it's going to be removed soon.
> If the state does change over suspend, users will simply have to prod
> rfkill-input twice in order to toggle the state.
> 
> Userspace policy agents will be able to implement a more consistent user
> experience.  For example, they can avoid the above problem if they
> toggle devices individually.  Then there would be no "global state"
> to get out of sync.
> 
> Currently there are only two rfkill drivers with persistent soft-blocked
> state.  thinkpad-acpi already checks the software state on resume.
> eeepc-laptop will require modification.
> 
> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> CC: Marcel Holtmann <marcel@holtmann.org>

looks good to me and is way better than using a complicated API for this
non-volatile storage details.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel