From: Johannes Berg <johannes@sipsolutions.net>
To: Andrey Yurovsky <andrey@cozybit.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] cfg80211: allow adding/deleting stations on mesh
Date: Tue, 16 Jun 2009 20:35:07 +0200 [thread overview]
Message-ID: <1245177307.21287.34.camel@johannes.local> (raw)
In-Reply-To: <1245177064-31861-1-git-send-email-andrey@cozybit.com>
[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]
On Tue, 2009-06-16 at 11:31 -0700, Andrey Yurovsky wrote:
> Commit b2a151a288 added a check that prevents adding or deleting
> stations on non-AP interfaces. Adding and deleting stations is
> supported for Mesh Point interfaces, so add Mesh Point to that check as
> well.
Why? Aren't those automatically discovered like IBSS peers?
johannes
> Signed-off-by: Andrey Yurovsky <andrey@cozybit.com>
> ---
> net/wireless/nl80211.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index e18856c..b28c641 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -1763,7 +1763,8 @@ static int nl80211_new_station(struct sk_buff *skb, struct genl_info *info)
> goto out_rtnl;
>
> if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
> - dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN) {
> + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN &&
> + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_MESH_POINT) {
> err = -EINVAL;
> goto out;
> }
> @@ -1812,7 +1813,8 @@ static int nl80211_del_station(struct sk_buff *skb, struct genl_info *info)
> goto out_rtnl;
>
> if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
> - dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN) {
> + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN &&
> + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_MESH_POINT) {
> err = -EINVAL;
> goto out;
> }
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-06-16 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 18:31 [PATCH] cfg80211: allow adding/deleting stations on mesh Andrey Yurovsky
2009-06-16 18:35 ` Johannes Berg [this message]
2009-06-16 18:42 ` Andrey Yurovsky
2009-06-16 18:45 ` Johannes Berg
2009-06-16 18:55 ` Andrey Yurovsky
2009-06-16 18:56 ` Johannes Berg
2009-06-16 19:32 ` Javier Cardona
2009-06-16 19:37 ` Johannes Berg
2009-06-16 19:51 ` Javier Cardona
2009-06-16 19:59 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245177307.21287.34.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=andrey@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox