Re: [PATCH 21/23] orinoco: convert scanning to cfg80211

Dave
2009-06-19T21:25:57Z

John W. Linville wrote:
> On Fri, Jun 19, 2009 at 06:52:45PM +0100, Dave wrote:
>> John W. Linville wrote:
>>> Hmmm...please do try to compile test patches before posting! :-)

>> Compile? I'm running it! (and sparse didn't complain either)
>>
>> I'll go have a look see what's special on my end. I'm guessing no SMP or
>> something.
>
> Haha...yeah, that's probably it...
>
>> Would you like the series/patch reposted including this fix?
>
> No, I've got it fixed.

Thanks.

It looks like I can enable DEBUG_SPINLOCKS to highlight this - but it's
expensive to keep turning that on and off.

Alternatively I could submit a patch to either add typechecks to
spinlock_api_up.h or convert the #defines to inlines.

Sounds a bit too controversial for me, so I'll just try to be vigilant
for now.

Regards,

Dave.