Re: [PATCH] wext: optimise, comment and fix event sending

Johannes Berg
2009-06-20T11:32:55Z

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

On Fri, 2009-06-19 at 10:59 -0700, Luis R. Rodriguez wrote:

> > /* Get the description of the Event */
> > if (cmd <= SIOCIWLAST) {
> > @@ -1430,25 +1395,60 @@ void wireless_send_event(struct net_devi
> > hdr_len = event_type_size[descr->header_type];
> > event_len = hdr_len + extra_len;
> >
> > - /* Create temporary buffer to hold the event */
> > - event = kmalloc(event_len, GFP_ATOMIC);
>
> Hm, for stable purposes can this be fixed with a kzalloc here? If so
> can this patch be split it up in 2 for that purpose?

Yes, but since this bug has been around _forever_, and we've also known
about it for a long time too, I don't think it's necessary to fix in
stable.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]