From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wext: optimise, comment and fix event sending
Date: Sat, 20 Jun 2009 13:32:51 +0200 [thread overview]
Message-ID: <1245497571.16399.25.camel@johannes.local> (raw)
In-Reply-To: <43e72e890906191059m321907dbr98395dda9e16b139@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Fri, 2009-06-19 at 10:59 -0700, Luis R. Rodriguez wrote:
> > /* Get the description of the Event */
> > if (cmd <= SIOCIWLAST) {
> > @@ -1430,25 +1395,60 @@ void wireless_send_event(struct net_devi
> > hdr_len = event_type_size[descr->header_type];
> > event_len = hdr_len + extra_len;
> >
> > - /* Create temporary buffer to hold the event */
> > - event = kmalloc(event_len, GFP_ATOMIC);
>
> Hm, for stable purposes can this be fixed with a kzalloc here? If so
> can this patch be split it up in 2 for that purpose?
Yes, but since this bug has been around _forever_, and we've also known
about it for a long time too, I don't think it's necessary to fix in
stable.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-06-20 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 14:28 [PATCH] wext: optimise, comment and fix event sending Johannes Berg
2009-06-19 17:59 ` Luis R. Rodriguez
2009-06-20 11:32 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245497571.16399.25.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox