Re: [PATCH 1/2 RFC] cfg80211: connect/disconnect API

Johannes Berg
2009-06-22T19:08:42Z

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

On Mon, 2009-06-22 at 19:04 +0200, Samuel Ortiz wrote:

> /**
> + * struct cfg80211_connect_params - Connection parameters
> + *
> + * This structure provides information needed to complete IEEE 802.11
> + * authentication and association.
> + *
> + * @channel: The channel to use or %NULL if not specified (auto-select based
> + * on scan results)
> + * @bssid: The AP BSSID or %NULL if not specified (auto-select based on scan
> + * results)
> + * @ssid: SSID
> + * @ssid_len: Length of ssid in octets
> + * @auth_type: Authentication type (algorithm)
> + * @assoc_ie: IEs for association request
> + * @assoc_ie_len: Length of assoc_ie in octets
> + * @control_port: Whether user space controls IEEE 802.1X port, i.e.,
> + * sets/clears %NL80211_STA_FLAG_AUTHORIZED. If true, the driver is
> + * required to assume that the port is unauthorized until authorized by
> + * user space. Otherwise, port is marked authorized by default.

One question I just had -- if bssid is NULL, and the card selects the
BSSID, I suppose it will also roam by itself if it can [1]. Don't we
need a "roamed" event for that then, even if we're not yet adding a
->roam() call?

johannes

[1] yes, we need to have a way to export roaming capabilities of the
card to user space