From: Marcel Holtmann <marcel@holtmann.org>
To: Luciano Coelho <luciano.coelho@nokia.com>
Cc: ext Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>,
Reinette Chatre <reinette.chatre@intel.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: fix aggregation limit
Date: Wed, 01 Jul 2009 09:02:13 -0700 [thread overview]
Message-ID: <1246464133.12994.155.camel@localhost.localdomain> (raw)
In-Reply-To: <4A4B862C.7080709@nokia.com>
Hi Johannes,
> >>> According to the documentation, the limit is 0x3f == 63, not 64.
> >>>
> >>> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> >>> ---
> >>> It seems bug 2018 is related to the link quality command, because it
> >>> seems I can trivially trigger it or similar bugs that way, but this
> >>> doesn't fix it.
> >>>
> >>> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:33.804427206 +0200
> >>> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-commands.h 2009-07-01 14:53:38.924427592 +0200
> >>> @@ -1922,7 +1922,7 @@ struct iwl_link_qual_general_params {
> >>> #define LINK_QUAL_AGG_DISABLE_START_MIN (0)
> >>>
> >>> #define LINK_QUAL_AGG_FRAME_LIMIT_DEF (31)
> >>> -#define LINK_QUAL_AGG_FRAME_LIMIT_MAX (64)
> >>> +#define LINK_QUAL_AGG_FRAME_LIMIT_MAX 0x3f
> >>> #define LINK_QUAL_AGG_FRAME_LIMIT_MIN (0)
> >>>
> >> why are you switching of hex now? Just putting (63) in there is not
> >> enough?
> >>
> >
> > It would be, obviously, but the doc says 0x3f.
> >
>
> I think it would be nicer to have (63) or otherwise convert all the
> macros to use the 0x format. Does the spec use 0x1f for the default
> value, for instance, instead of (31)?
I would agree. Use (31) and let the commit message explain it. Not that
it is really that important.
Regards
Marcel
prev parent reply other threads:[~2009-07-01 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 12:57 [PATCH] iwlwifi: fix aggregation limit Johannes Berg
2009-07-01 15:06 ` Marcel Holtmann
2009-07-01 15:09 ` Johannes Berg
2009-07-01 15:52 ` Luciano Coelho
2009-07-01 16:02 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246464133.12994.155.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luciano.coelho@nokia.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox