Re: [PATCH 8/8 v3.1] mac80211: re-add HT disabling

Jouni Malinen
2009-07-02T09:51:44Z

On Wed, Jul 01, 2009 at 12:42:39PM +0200, Johannes Berg wrote:
> On Wed, 2009-07-01 at 15:43 +0530, Vasanthakumar Thiagarajan wrote:
> > On Wed, Jul 01, 2009 at 01:09:16PM +0530, Johannes Berg wrote:
> > > @@ -1236,6 +1236,14 @@ static int ieee80211_assoc(struct wiphy
> > > + for (i = 0; i < req->crypto.n_ciphers_pairwise; i++)
> > > + if (req->crypto.ciphers_pairwise[i] == WLAN_CIPHER_SUITE_WEP40 ||

> > for..loop does not seem to be necessary here as it is very unlikely that
> > an assoc req will have more than one cipher suite.

> True, but so far we've defined the API that way. Should we redefine the
> API? I keep forgetting what is valid where. Jouni?

The (re)association request is only allowed to list one pairwise cipher
suite (see IEEE 802.11, 8.4.3). Various other use cases for RSN IE
support multiple cipher suites, but this one does not.

--
Jouni Malinen PGP id EFC895FA