Re: [PATCH] rfkill: prep for rfkill API changes

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

On Sun, 2009-07-05 at 10:24 -0300, Henrique de Moraes Holschuh wrote:

> This is good, but not complete.  Changes to the API that don't change the
> size (or those which reduces it) are a problem: they are impossible with a
> schema that detects API version by the size alone.

Umm, no, we can also add operations as required already.

> Maybe a new field with a API serial number should be added right _now_ while
> it is still not too painful to do it?  This would be V2 of the API
> (detectable by the size change), but there aren't many users yet, so the
> effort to support it would not be daunting.
> 
> You can also publish the API version through a read-only sysfs attribute or
> a separate IOCTL... it doesn't really need to be in-band (although in-band
> is a lot better).

No.

This patch doesn't change anything at all. It just reduces the
_subtlety_ involved in actually doing a size change, nothing more. A
real event version is _not_ necessary at all. In fact, I would argue
that basing _anything_ on the "version" rather than the "feature set" is
useless.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]