From: Johannes Berg <johannes@sipsolutions.net>
To: javier@cozybit.com
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org,
Andrey Yurovsky <andrey@cozybit.com>
Subject: Re: [PATCH v2] Fix regression in mesh forwarding path.
Date: Tue, 07 Jul 2009 03:40:56 +0200 [thread overview]
Message-ID: <1246930856.4652.11.camel@johannes.local> (raw)
In-Reply-To: <1246929954-15282-1-git-send-email-javier@cozybit.com>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Mon, 2009-07-06 at 18:25 -0700, javier@cozybit.com wrote:
>
> while ((skb = skb_dequeue(&mpath->frame_queue)) &&
> (mpath->flags & MESH_PATH_ACTIVE))
> - dev_queue_xmit(skb);
> + ieee80211_add_pending_skb(mpath->sdata->local, skb);
> }
?
Hmm, now I'm confused, why not just do
if (mpath->flags & MESH_PATH_ACTIVE)
ieee80211_add_pending_skbs(mpath->sdata->local,
&mpath->frame_queue);
?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-07-07 1:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 0:47 [PATCH] Fix regression in mesh forwarding path javier
2009-07-07 0:52 ` javier
2009-07-07 1:06 ` Johannes Berg
2009-07-07 1:25 ` [PATCH v2] " javier
2009-07-07 1:40 ` Johannes Berg [this message]
2009-07-07 3:03 ` Javier Cardona
2009-07-07 2:54 ` [PATCH v3] " javier
2009-07-07 8:50 ` Johannes Berg
2009-07-07 15:30 ` [PATCH v4] " Javier Cardona
2009-07-07 17:03 ` [PATCH v3] " John W. Linville
2009-07-07 17:55 ` [PATCH v5] " javier
2009-07-10 18:51 ` [PATCH v5] mac80211: " John W. Linville
2009-07-10 19:04 ` Andrey Yurovsky
2009-07-07 1:35 ` [PATCH] " Javier Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246930856.4652.11.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=andrey@cozybit.com \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).