From: Johannes Berg <johannes@sipsolutions.net>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-wireless@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Possible memory leak in net/wireless/scan.c
Date: Tue, 07 Jul 2009 23:47:21 +0200 [thread overview]
Message-ID: <1247003241.4755.55.camel@johannes.local> (raw)
In-Reply-To: <1247002168.5710.1.camel@pc1117.cambridge.arm.com>
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
On Tue, 2009-07-07 at 22:29 +0100, Catalin Marinas wrote:
> > > if (found) {
> > > - kref_get(&found->ref);
> > > found->pub.beacon_interval = res->pub.beacon_interval;
> > > found->pub.tsf = res->pub.tsf;
> > > found->pub.signal = res->pub.signal;
> > >
> > > I'll try this later today to see if it fixes the leak. If that's not
> > > correct, I'll post more information about the content of the reported
> > > object (in general, it shouldn't be on any valid list or rb tree since
> > > kmemleak can't find it).
> >
> > I have already sent that exact patch.
>
> OK. I can now confirm that it fixes the memory leak.
Great, thanks for checking.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-07-07 21:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 17:04 Possible memory leak in net/wireless/scan.c Catalin Marinas
2009-07-07 17:12 ` Johannes Berg
2009-07-07 21:29 ` Catalin Marinas
2009-07-07 21:47 ` Johannes Berg [this message]
2009-07-08 3:06 ` Johannes Berg
2009-07-08 8:46 ` Catalin Marinas
2009-07-08 10:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247003241.4755.55.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox