Re: Possible memory leak in net/wireless/scan.c

Johannes Berg
2009-07-07T17:13:23Z

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

On Tue, 2009-07-07 at 18:04 +0100, Catalin Marinas wrote:

> diff --git a/net/wireless/scan.c b/net/wireless/scan.c
> index e95b638..f8e71b3 100644
> --- a/net/wireless/scan.c
> +++ b/net/wireless/scan.c
> @@ -366,7 +366,6 @@ cfg80211_bss_update(struct cfg80211_registered_device *dev,
> found = rb_find_bss(dev, res);
>
> if (found) {
> - kref_get(&found->ref);
> found->pub.beacon_interval = res->pub.beacon_interval;
> found->pub.tsf = res->pub.tsf;
> found->pub.signal = res->pub.signal;
>
> I'll try this later today to see if it fixes the leak. If that's not
> correct, I'll post more information about the content of the reported
> object (in general, it shouldn't be on any valid list or rb tree since
> kmemleak can't find it).

I have already sent that exact patch.