From: Javier Cardona <javier@cozybit.com>
To: linux-wireless@vger.kernel.org
Cc: devel@lists.open80211s.org, johannes@sipsolutions.net,
Javier Cardona <javier@cozybit.com>
Subject: [PATCH] Assign next hop address to pending mesh frames once the path is resolved.
Date: Tue, 7 Jul 2009 22:53:23 -0700 [thread overview]
Message-ID: <1247032403-8312-1-git-send-email-javier@cozybit.com> (raw)
In-Reply-To: <>
Regression. Frames transmitted when a mesh path was wating to be resolved were
being transmitted with an invalid Receiver Address.
Signed-off-by: Javier Cardona <javier@cozybit.com>
---
net/mac80211/mesh.h | 2 +-
net/mac80211/mesh_pathtbl.c | 18 +++++++++++++++++-
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
index 2a2ed18..1827725 100644
--- a/net/mac80211/mesh.h
+++ b/net/mac80211/mesh.h
@@ -61,7 +61,7 @@ enum mesh_path_flags {
* retry
* @discovery_retries: number of discovery retries
* @flags: mesh path flags, as specified on &enum mesh_path_flags
- * @state_lock: mesh pat state lock
+ * @state_lock: mesh path state lock
*
*
* The combination of dst and sdata is unique in the mesh path table. Since the
diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c
index ae98766..75a13ee 100644
--- a/net/mac80211/mesh_pathtbl.c
+++ b/net/mac80211/mesh_pathtbl.c
@@ -55,7 +55,23 @@ static DEFINE_RWLOCK(pathtbl_resize_lock);
*/
void mesh_path_assign_nexthop(struct mesh_path *mpath, struct sta_info *sta)
{
- rcu_assign_pointer(mpath->next_hop, sta);
+ struct sk_buff *skb, *skb_first = NULL;
+ struct ieee80211_hdr *hdr;
+
+ rcu_read_lock();
+ mpath->next_hop = sta;
+
+ while ((skb = skb_dequeue(&mpath->frame_queue)) != skb_first) {
+ if (!skb_first)
+ skb_first = skb;
+ hdr = (struct ieee80211_hdr *) skb->data;
+ memcpy(hdr->addr1, sta->sta.addr, ETH_ALEN);
+ skb_queue_tail(&mpath->frame_queue, skb);
+ }
+ if (skb_first)
+ skb_queue_tail(&mpath->frame_queue, skb_first);
+
+ rcu_read_unlock();
}
--
1.5.4.3
next reply other threads:[~2009-07-08 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 5:53 Javier Cardona [this message]
2009-07-08 10:40 ` [PATCH] Assign next hop address to pending mesh frames once the path is resolved Johannes Berg
2009-07-08 17:02 ` Javier Cardona
2009-07-09 21:42 ` [PATCH v2] " Javier Cardona
2009-07-09 21:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247032403-8312-1-git-send-email-javier@cozybit.com \
--to=javier@cozybit.com \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox