From: Marcel Holtmann <marcel@holtmann.org>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h
Date: Wed, 08 Jul 2009 12:32:37 -0700 [thread overview]
Message-ID: <1247081557.9709.16.camel@localhost.localdomain> (raw)
In-Reply-To: <1247068554.4382.106.camel@ht.satnam>
Hi Jaswinder,
> fix the following 'make includecheck' warning:
>
> include/linux/rfkill.h: linux/types.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> include/linux/rfkill.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index e73e242..2ce2983 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -99,7 +99,6 @@ enum rfkill_user_states {
> #undef RFKILL_STATE_UNBLOCKED
> #undef RFKILL_STATE_HARD_BLOCKED
>
> -#include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/list.h>
> #include <linux/mutex.h>
with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
correct.
Regards
Marcel
next prev parent reply other threads:[~2009-07-08 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1247063308.4382.12.camel@ht.satnam>
2009-07-08 15:55 ` [PATCH 41/44] includecheck fix: include/linux, rfkill.h Jaswinder Singh Rajput
2009-07-08 19:32 ` Marcel Holtmann [this message]
2009-07-09 4:01 ` Jaswinder Singh Rajput
2009-07-09 5:47 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247081557.9709.16.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=akpm@linux-foundation.org \
--cc=jaswinder@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).