* [PATCH] cfg80211: fix wext setting SSID
@ 2009-07-10 16:35 Johannes Berg
2009-07-10 16:41 ` Pavel Roskin
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2009-07-10 16:35 UTC (permalink / raw)
To: John Linville; +Cc: Pavel Roskin, linux-wireless
Pavel reported that you can't set the SSID from "foo" to
"bar". I tried reproducing, but used different values,
with different lengths, and thus never saw the obvious
problem.
Reported-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
*sigh*
tons of stupid mistakes
net/wireless/wext-sme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- wireless-testing.orig/net/wireless/wext-sme.c 2009-07-10 18:33:59.000000000 +0200
+++ wireless-testing/net/wireless/wext-sme.c 2009-07-10 18:34:08.000000000 +0200
@@ -166,7 +166,7 @@ int cfg80211_mgd_wext_siwessid(struct ne
if (wdev->wext.connect.ssid && len &&
len == wdev->wext.connect.ssid_len &&
- memcmp(wdev->wext.connect.ssid, ssid, len))
+ memcmp(wdev->wext.connect.ssid, ssid, len) == 0)
goto out;
if (wdev->sme_state != CFG80211_SME_IDLE) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cfg80211: fix wext setting SSID
2009-07-10 16:35 [PATCH] cfg80211: fix wext setting SSID Johannes Berg
@ 2009-07-10 16:41 ` Pavel Roskin
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Roskin @ 2009-07-10 16:41 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, linux-wireless
On Fri, 2009-07-10 at 18:35 +0200, Johannes Berg wrote:
> Pavel reported that you can't set the SSID from "foo" to
> "bar". I tried reproducing, but used different values,
> with different lengths, and thus never saw the obvious
> problem.
>
> Reported-by: Pavel Roskin <proski@gnu.org>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Tested-by: Pavel Roskin <proski@gnu.org>
> *sigh*
> tons of stupid mistakes
Two mistakes less. Thank you!
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-10 16:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-10 16:35 [PATCH] cfg80211: fix wext setting SSID Johannes Berg
2009-07-10 16:41 ` Pavel Roskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).