From: reinette chatre <reinette.chatre@intel.com>
To: "timg@tpi.com" <timg@tpi.com>
Cc: "Zhu, Yi" <yi.zhu@intel.com>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi 3945: Fix IWL_SCAN compile error
Date: Mon, 13 Jul 2009 13:14:14 -0700 [thread overview]
Message-ID: <1247516054.17896.1634.camel@rc-desk> (raw)
In-Reply-To: <4A5B9388.4030208@tpi.com>
Hi Tim,
On Mon, 2009-07-13 at 13:05 -0700, Tim Gardner wrote:
> reinette chatre wrote:
> > Hi Tim,
> >
> > On Mon, 2009-07-13 at 12:08 -0700, Tim Gardner wrote:
> >> From 2c7c806570ad72f5af2e778f2fe71aae7d727e02 Mon Sep 17 00:00:00 2001
> >> From: Tim Gardner <tim.gardner@canonical.com>
> >> Date: Mon, 13 Jul 2009 12:53:32 -0600
> >> Subject: [PATCH] iwlwifi 3945: Fix IWL_DEBUG_SCAN compile
> >>
> >> Added a missing parameter in the macro invocation to correct a
> >> compile error when CONFIG_IWLWIFI_DEBUG is enabled.
> >>
> >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> >> ---
> >> drivers/net/wireless/iwlwifi/iwl3945-base.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> >> index 2564288..67332fb 100644
> >> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> >> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> >> @@ -2962,7 +2962,7 @@ static void iwl3945_bg_request_scan(struct work_struct *data)
> >> }
> >>
> >> if (scan->channel_count == 0) {
> >> - IWL_DEBUG_SCAN("channel count %d\n", scan->channel_count);
> >> + IWL_DEBUG_SCAN(priv,"channel count %d\n", scan->channel_count);
> >> goto done;
> >> }
> >>
> >
> > On which code did you base this patch?
> >
> > Reinette
> >
> >
>
> Head of Linus' tree, but I see that its already fixed in
> wireless-testing. I guess I pulled the trigger too soon.
I just pulled the latest from Linus but cannot see this problem. We also
do not have anything related to this pending for 2.6.31.
Reinette
next prev parent reply other threads:[~2009-07-13 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 19:08 [PATCH] iwlwifi 3945: Fix IWL_SCAN compile error Tim Gardner
2009-07-13 20:03 ` reinette chatre
2009-07-13 20:05 ` Tim Gardner
2009-07-13 20:14 ` reinette chatre [this message]
2009-07-13 20:47 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247516054.17896.1634.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=timg@tpi.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).