Re: [PATCH 01/21] mac80211: drop frames for sta with no valid rate

Johannes Berg
2009-07-15T16:06:37Z

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Wed, 2009-07-15 at 07:56 -0700, Luis R. Rodriguez wrote:
> On Wed, Jul 15, 2009 at 04:58:41AM -0700, Johannes Berg wrote:
> > On Tue, 2009-07-14 at 20:13 -0400, Luis R. Rodriguez wrote:
> >
> > > + if (unlikely((tx->local->sw_scanning) &&
> > > + (sta_flags & WLAN_STA_ASSOC) &&
> > > + !rate_usable_index_exists(sband, &tx->sta->sta))) {
> > > +#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
> > > + printk(KERN_DEBUG "%s: dropped data frame -- no "
> > > + "supported rate for station %pM on %c GHz band\n",
> > > + tx->dev->name, hdr->addr1,
> > > + tx->channel->band ? '5' : '2');
> > > +#endif /* CONFIG_MAC80211_VERBOSE_DEBUG */
> > > + WARN_ON(1);
> > > + return TX_DROP;
> >
> > Can you use WARN(),
>
> sure.
>
> > and put it into the if() please?
>
> It is already in the if() branch, do you mean in the #ifdef?

No, I mean if (WARN(...)) return TX_DROP;

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]